I decided to switch to HTML5, and here is the first layout - websterjoy.tk. I want to know which html5 tags I used where I needed, which ones were not at the destination, and in general the markup mark. Thank you in advance.
- everything is fine, only section of the article should be replaced with the article - Arc
|
1 answer
I see that you took into account my past remarks and this time the layout was done qualitatively, with the exception of a few remarks:
- I understand that you are showing us the layout of the product card? It will naturally wrap the name of the product in h1, and not in h2. You use h1 for the expression "Product Catalog", which is also not good. If you honestly did not understand the purpose of this expression for this page, but this is a question for the designer, what he meant. It’s better to wrap it in a span instead of a heading. Again, advice in terms of SEO.
- I see you use the sprite to merge small images, fine! But why not all the pictures combined?
- <a onclick="look('div1', this);"> ... </a> - this is not good. Deliver the logic into a separate script or <script> block ... </ script>
- Stick to one style: either plain html or strict (xhtml). And then you have somewhere ../> and somewhere just>.
- A small wish: if you have a link to skype and icq on your page, you can make life a little easier for users as follows .
UPDATE: Well, since you are using jQuery on the site, I will write a script with it:
$(function() { $('.turn').on('click', function( e ){ e.preventDefault(); $('#div1').toggle(); var text = $(this).text(); text = (text == 'Свернуть ↑') ? 'Развернуть ↓' : 'Свернуть ↑'; $(this).text(text); }); }); In the link with the 'turn' class, remove the onClick attribute and add the href = "#" attribute.
- Thanks again for the tips! I fix it. Only at the expense of JS, can you please in more detail, where to take it out? the script is from the network, but I don’t understand anything in JS - websterjoy
- Everything is working! Thank. - websterjoy
|