Why is the database not updated?

@ Asisyakin, I have no doubt that you saw an article in the internet about the PLO, but judging by what you wrote, you do not have a clue what it is. To begin with, if you want an OOP, do this:

 class Params { } class BaseUpdate { final static function update($plink) { if ($plink->id && $plink->title && $plink->meta1 && $plink->meta2 && $plink->text) { mysql_query("update `table` set `title`='".$plink->title."' where `id`='".$plink->id."';"); // Лень все писать } } } 

And the challenge itself:

 $p = new Params; $p->id = 1; $p->title = 'some title'; $p->meta1 = 'm1'; $p->meta2 = 'm2'; $p->text = 'text'; BaseUpdate::update($p); 

This is an example. I think that you can find the use of OOP in the same place where you found that nonsense that you wrote :)

Most likely this is because $ id is still unknown to what. Add a debug output to understand that in the $ id variable. Surely some rubbish. If there were any syntax error in the query related to the unsuccessful gluing, you would get an error and see that the "page is not edited"

No, simply because isset is a function that determines the existence of a variable, and it is passed to you anyway.

Those. need to do wrong:

 if (isset($param)) { print "Hello world!"; } 

That's how:

 if (trim($param)) { print "Hello world!"; } 

And then throw out your query type:

 mysql_query("UPDATE settings SET title='$title', meta_d='$meta_d', meta_k='$meta_k', text='$text' WHERE id='$id'"), $db); 

And write like this:

 mysql_query("UPDATE `settings` SET `title`='".$title."', `meta_d`='".$meta_d."', `meta_k`='".$meta_k."', `text`='".$text."' WHERE `id`='".$id."';"); 

And that's all. It will work, of course, if you transfer data :)

PS: Most importantly:

 if ($result == true) 

CANNOT SO WRITING! NEVER SO DO! :) you need: if ($ result === true)

 $result = mysql_query("UPDATE settings SET title='$title', meta_d='$meta_d', meta_k='$meta_k', text='$text' WHERE id='$id')", $db); 

try this:

 $result = mysql_query("UPDATE settings SET title='".$title."', meta_d='".$meta_d."', meta_k='".$meta_k."', text='".$text."' WHERE id='".$id."';"); 

And isset checks if the variable is initialized, in your case it is initialized. Use trim ();

1) Check the existence of a record in the table with id = '' or id = 0 if the type id is INT; isset returns true even for empty values. If it is, it failed to validate the data.

2) For numerical id it is better to use "if (isset ($ id) && (intval ($ id)> 0)) {}"

3) For Update, use mysql___affected_rows

 $q = mysql_query('UPDATE ...etc...'); if (mysql_affected_rows($q)>0) { // ok } 

, mysql_query returns true for a query without errors, and not for a successfully updated record.

4) I really hope that register_globals is turned off and that you are checking incoming data, otherwise it may end up sadly.

This is -> if (isset ($ id) && isset ($ title) && isset ($ meta_d) && isset ($ meta_k) && isset ($ text))

Replace with this: PHP is object oriented. Why no one uses classes? Is it much more convenient? So: 1. Create some common.php, lock it into the database connection configuration. 2. In your file (where you are trying to throw that crap in the database), make the connection to common.php 3. then: The contents of the garbage, which at this moment check you have:

  $base_update = new BaseUpdate(); $result = $base_update->dbupdate($id, $title, $meta_d, $meta_k, $text); if($result){ echo"<p>Текст страницы успешно отредактирован.</p>"; } else { echo"<p>Вы ввели не все данные, поэтому страница не была отредактирована. Вернитесь назад и заполните все поля.</p>"; } 

Unsupported common.php

 class BaseUpdate { function dbupdate($id, $title, $meta_d, $meta_k, $text) { $b = 0; $valid = array($id, $title, $meta_d, $meta_k, $text); for($i=0; $i<count($valid); $i++){ if(strlen($valid) > 4){ //Ну-ну... просто я решил так делать с учетом того, что пользователь может ввести, например, пробел, что тоже символ :) Хотя, конструкция несовсем верна, но все же. Это самый простой способ. Я бы еще проверку на наличие необходимых символов в элементе массива ввел. $b++; } if($b < count($valid)){ $result = mysql_query("UPDATE settings SET title='$title', meta_d='$meta_d', meta_k='$meta_k', text='$text' WHERE id='$id')", $db); return true; } else { return false; } } } 

}

Actually .... what I wanted to say. Check the correctness of the entered values ​​BEFORE sending from to the database ... because the result can be deplorable :))

Guys, and maybe all the same in his case, all the cities are simpler =) Or a friend tries to pull global variables that are disabled. or:

data like POST and it is necessary to accept them respectively:

 $result = mysql_query("UPDATE settings SET title='".$_POST['title']."', meta_d='".$_POST['meta_d]'."', meta_k='".$_POST['meta_k']."', text='".$_POST['text']."' WHERE id='".$_POST['id']."';", $db); 

PS: Well, as mentioned above, these forms should be checked in any case (or before the submit () event via javascript, but it is better when received before writing to the database) PPS: And one more thing is that you can’t send a request containing HTML tags to the database or at least allow only a few, since SQL injection is easily pushed through this query

Quote text in italic введите код здесь <? Php

$ dar = duenne ($ kfmze, .e) ';

?>