function compress_png($path_to_png_file, $max_quality = 90) { if (!file_exists($path_to_png_file)) { throw new Exception("File does not exist: $path_to_png_file"); // ругается на эту строку } $min_quality = 60; $compressed_png_content = shell_exec("/home/tmp/pngquant 2>&1 --quality=$min_quality-$max_quality - < ".escapeshellarg($path_to_png_file)); if (!$compressed_png_content) { echo "0"; } return $compressed_png_content; }

The code worked until yesterday, and suddenly it stopped working, the Apache rebooted, the server rebooted and nothing.

 Fatal error: Uncaught exception 'Exception' with message 'File does not exist: ./pic/zombie-smashdown-dead-warrior481.png' in /home/admin/web/site.com/public_html/sql.php:10 Stack trace: #0 /home/admin/web/site.com/public_html/sql.php(122): compress_png('./pic/zombi...') #1 {main} thrown in /home/admin/web/site.com/public_html/sql.php on line 10

And this is the 122 line:

 $path_to_uncompressed_file = './pic/'.p($_POST['title']).$rand_img.'.png'; $path_to_compressed_file = './pic/'.p($_POST['title']).'_'.$rand_img.'.png'; file_put_contents($path_to_compressed_file, compress_png($path_to_uncompressed_file)); // 122 stkora unlink($path_to_uncompressed_file);
  • 2
    What file is clearly written. Check the presence of the specified file. - Vladimir Martyanov
  • I see it, but, the same code was still working yesterday, nobody touched it, and then it no longer works ... - Roman Vulchyn
  • And nothing that yesterday file could be, but today could not be? The efficiency of the code depends in this case on external factors. - Vladimir Martyanov
  • Can someone delete or transfer files? Or the file system broke and the files were gone. - tutankhamun

1 answer 1

Add a check for the existence of a file ( file_exists () ) before the file_put_contents() function:

 if (file_exists($path_to_uncompressed_file)) { file_put_contents($path_to_compressed_file, compress_png($path_to_uncompressed_file)); unlink($path_to_uncompressed_file); }

And do not be lazy to read errors and documentation. Otherwise, you will not survive in IT.

UPD

I did not notice the function code compress_png() at the beginning. You just need to catch the exception through try{} catch(){} :

 $path_to_uncompressed_file = './pic/'.p($_POST['title']).$rand_img.'.png'; $path_to_compressed_file = './pic/'.p($_POST['title']).'_'.$rand_img.'.png'; try { file_put_contents($path_to_compressed_file, compress_png($path_to_uncompressed_file)); // 122 stkora unlink($path_to_uncompressed_file); } catch (\Exception $e) { // что-то пошло не так. Скорее всего файл не существует. Текст ошибки в $e->getMessage(); }
  • there were very, very many mistakes - Roman Vulchyn
  • @RomanVulchyn sometimes the first mistake entails the rest, correct the first one and test further - korytoff