Everything works, but the data is not inserted into the database table. What can be wrong?

<?php header('Content-Type: text/html; charset=utf-8'); if ($_POST) //УсловиС Π±ΡƒΠ΄Π΅Ρ‚ Π²Ρ‹ΠΏΠΎΠ»Π½Π΅Π½ΠΎ, Ссли ΠΏΡ€ΠΎΠΈΠ·Π²Π΅Π΄Π΅Π½ POST-запрос ΠΊ скрипту. { $name = trim($_POST['rname']); $login = trim($_POST['rlogin']); $password = trim($_POST['rpass']); $password_r = trim($_POST['rpass_r']); $email = trim($_POST['email']); $data = date('y,n,d'); $error = false;//Π‘ΠΎΠ·Π΄Π°Π΅ΠΌ ΠΏΠ΅Ρ€Π΅ΠΌΠ΅Π½Π½ΡƒΡŽ, ΠΊΠΎΠ½Ρ‚Ρ€ΠΎΠ»ΠΈΡ€ΡƒΡŽΡ‰ΡƒΡŽ ошибки рСгистрации. $errortext = "<p><b><font color='red'><h3>ΠŸΡ€ΠΈ рСгистрации Π½Π° сайтС ΠΏΡ€ΠΎΠΈΠ·ΠΎΡˆΠ»ΠΈ ΡΠ»Π΅Π΄ΡƒΡŽΡ‰ΠΈΠ΅ ошибки:</h3></font></p><ul>"; if (empty($name)) { $error = true; $errortext .= "<li><font color='red'>Π’Ρ‹ Π½Π΅ Π·Π°ΠΏΠΎΠ»Π½Π΅Π»ΠΈ ΠΏΠΎΠ»Π΅ Имя ΠΏΠΎΠ»ΡŒΠ·ΠΎΠ²Π°Ρ‚Π΅Π»Ρ!</font></li>"; } else { if (!preg_match("/^[az Π°-яё]{2,30}$/iu",$name)) { $error = true; $errortext .= "<li><font color='red'>Π£Π±Π΅Π΄ΠΈΡ‚Π΅ΡΡŒ Ρ‡Ρ‚ΠΎ Имя содСрТит ΠΎΡ‚ 2 Π΄ΠΎ 30 символов ΠΈ Π½Π΅ содСрТит Ρ†ΠΈΡ„Ρ€</font></li>"; } } if (empty($login)) { $error = true; $errortext .= "<li><font color='red'>Π’Ρ‹ Π½Π΅ Π·Π°ΠΏΠΎΠ»Π½ΠΈΠ»ΠΈ ΠΏΠΎΠ»Π΅ Π›ΠΎΠ³ΠΈΠ½ ΠΏΠΎΠ»ΡŒΠ·ΠΎΠ²Π°Ρ‚Π΅Π»Ρ!</font></li>"; } else { if (!preg_match("/^[a-z0-9]{2,20}$/i",$login)) { $error = true; $errortext .= "<li><font color='red'>Π£Π±Π΅Π΄ΠΈΡ‚Π΅ΡΡŒ Ρ‡Ρ‚ΠΎ Π›ΠΎΠ³ΠΈΠ½ содСрТит ΠΎΡ‚ 2 Π΄ΠΎ 20 символов, ΠΈ состоит ΠΈΠ· латинских символов ΠΈ Ρ†ΠΈΡ„Ρ€</font></li>"; } } if (empty($password)) { $error = true; $errortext .= "<li><font color='red'>Π’Ρ‹ Π½Π΅ Π·Π°ΠΏΠΎΠ»Π½ΠΈΠ»ΠΈ ΠΏΠΎΠ»Π΅ ΠŸΠ°Ρ€ΠΎΠ»ΡŒ!</font></li>"; } else { if (!preg_match("/^[a-z0-9]{3,20}$/i",$password)) { $error = true; $errortext .= "<li><font color='red'>Π£Π±Π΅Π΄ΠΈΡ‚Π΅ΡΡŒ Ρ‡Ρ‚ΠΎ ΠŸΠ°Ρ€ΠΎΠ»ΡŒ содСрТит ΠΎΡ‚ 3 Π΄ΠΎ 20 символов, ΠΈ состоит ΠΈΠ· латинских символов ΠΈ Ρ†ΠΈΡ„Ρ€</font></li>"; } } if (empty($password_r)) { $error = true; $errortext .= "<li><font color='red'>Π’Ρ‹ Π½Π΅ Π·Π°ΠΏΠΎΠ»Π½ΠΈΠ»ΠΈ ΠΏΠΎΠ»Π΅ ΠŸΠΎΠ΄Ρ‚Π²Π΅Ρ€ΠΆΠ΄Π΅Π½ΠΈΠ΅ пароля!</font></li>"; } else { if ($password != $password_r) { $error = true; $errortext .= "<li><font color='red'>ПолС ΠŸΠ°Ρ€ΠΎΠ»ΡŒ ΠΈ Π΅Π³ΠΎ ΠŸΠΎΠ΄Ρ‚Π²Π΅Ρ€ΠΆΠ΄Π΅Π½ΠΈΠ΅ Π½Π΅ ΡΠΎΠ²ΠΏΠ°Π΄Π°ΡŽΡ‚!</font></li>"; } } if (empty($email)) { $error = true; $errortext .= "<li><font color='red'>Π’Ρ‹ Π½Π΅ Π·Π°ΠΏΠΎΠ»Π½ΠΈΠ»ΠΈ ΠΏΠΎΠ»Π΅ E-Mail</font></li>"; } else { if (!preg_match("/^[-0-9a-z_\.]+@[-0-9a-z^\.]+\.[az]{2,4}$/i",$email)) { $error = true; $errortext .= "<li><font color='red'>НС ΠΏΡ€Π°Π²ΠΈΠ»ΡŒΠ½ΠΎ Π·Π°ΠΏΠΎΠ»Π½Π΅Π½ΠΎ ΠΏΠΎΠ»Π΅ E-Mail. E-mail Π΄ΠΎΠ»ΠΆΠ΅Π½ ΠΈΠΌΠ΅Ρ‚ΡŒ Π²ΠΈΠ΄ user@somehost.com</font></li>"; } } $errortext .= "</ul></b>"; if ($error) { echo($errortext);//Π’Ρ‹Π²ΠΎΠ΄ΠΈΠΌ тСкст ошибок. } else { //ΠŸΠΎΠ΄ΠΊΠ»ΡŽΡ‡Π°Π΅ΠΌΡΡ ΠΊ Π±Π°Π·Π΅ Π΄Π°Π½Π½Ρ‹Ρ…. $dbcon = mysql_connect("localhost", "root", "123456"); mysql_select_db("suitecrm", $dbcon); if (!$dbcon) { echo "<p>ΠŸΡ€ΠΎΠΈΠ·ΠΎΡˆΠ»Π° ошибка ΠΏΡ€ΠΈ подсоСдинСнии ΠΊ MySQL!</p>".mysqli_error(); exit(); } else { if (!mysql_select_db("suitecrm", $dbcon)) { echo("<p>Π’Ρ‹Π±Ρ€Π°Π½Π½ΠΎΠΉ Π±Π°Π·Ρ‹ Π΄Π°Π½Π½Ρ‹Ρ… Π½Π΅ сущСствуСт!</p>"); } } // ΠΏΡ€ΠΎΠ²Π΅Ρ€ΠΊΠ° Π½Π° сущСствованиС ΠΏΠΎΠ»ΡŒΠ·ΠΎΠ²Π°Ρ‚Π΅Π»Ρ с Ρ‚Π°ΠΊΠΈΠΌ ΠΆΠ΅ Π»ΠΎΠ³ΠΈΠ½ΠΎΠΌ. $result = mysql_query("SELECT id FROM users1 WHERE login='$login'",$dbcon); $myrow = mysql_fetch_array($result); if (!empty($myrow["id"])) { exit ("Π˜Π·Π²ΠΈΠ½ΠΈΡ‚Π΅, Π²Π²Π΅Π΄Ρ‘Π½Π½Ρ‹ΠΉ Π²Π°ΠΌΠΈ Π»ΠΎΠ³ΠΈΠ½ ΡƒΠΆΠ΅ зарСгистрирован.<a href='reg.php'> Π’Π²Π΅Π΄ΠΈΡ‚Π΅ Π΄Ρ€ΡƒΠ³ΠΎΠΉ Π»ΠΎΠ³ΠΈΠ½</a>."); } //ВыполняСм SQL-запрос Π·Π°ΠΏΠΈΡΡ‹Π²Π°ΡŽΡ‰ΠΈΠΉ Π΄Π°Π½Π½Ρ‹Π΅ ΠΏΠΎΠ»ΡŒΠ·ΠΎΠ²Π°Ρ‚Π΅Π»Ρ Π² Ρ‚Π°Π±Π»ΠΈΡ†Ρƒ. $sql = mysql_query("INSERT INTO users1 (name, login, password, email, data) Values ('$name', '$login', '$password', '$email', '$data')", $dbcon); if (!$sql) {echo "Запрос Π½Π΅ ΠΏΡ€ΠΎΡˆΠ΅Π». ΠŸΠΎΠΏΡ€ΠΎΠ±ΡƒΠΉΡ‚Π΅ Π΅Ρ‰Π΅ Ρ€Π°Π·.";} if ($sql) { //Π’Ρ‹Π²ΠΎΠ΄ΠΈΠΌ сообщСниС ΠΎΠ± ΡƒΡΠΏΠ΅ΡˆΠ½ΠΎΠΉ рСгистрации. exit ('<div align="center"><br/><br/><br/><h3> Π’Ρ‹ ΡƒΡΠΏΠ΅ΡˆΠ½ΠΎ зарСгистрированы Π½Π° сайтС! Π—Π°ΠΏΠΎΠ»Π½ΠΈΡ‚Π΅ Ρ„ΠΎΡ€ΠΌΡƒ Π²Ρ…ΠΎΠ΄Π° ΠΈ Π²ΠΎΠΉΠ΄ΠΈΡ‚Π΅</h3></div>'); } mysql_close($dbcon);//Π—Π°ΠΊΡ€Ρ‹Π²Π°Π΅ΠΌ соСдинСниС MySQL. } } if (($_POST && $error) || !$_POST) { } ?> 

Closed due to the fact that off-topic participants Dmitriy Simushev , aleksandr barakin , zRrr , cheops , PashaPash ♦ 11 May '16 at 6:51 .

It seems that this question does not correspond to the subject of the site. Those who voted to close it indicated the following reason:

  • β€œQuestions asking for help with debugging (β€œ why does this code not work? ”) Should include the desired behavior, a specific problem or error, and a minimum code for playing it right in the question . Questions without an explicit description of the problem are useless for other visitors. See How to create minimal, self-sufficient and reproducible example . " - Dmitriy Simushev, aleksandr barakin, zRrr, cheops, PashaPash
If the question can be reformulated according to the rules set out in the certificate , edit it .

  • one
    The mysql_query extension mysql_query long been outdated and is not supported in recent versions of php. use mysqli or pdo_mysql - Alex
  • Please specify. Do you receive any error or message? - Alex
  • @alina Please let us know if the form displays the message "Request failed. Please try again."? - cheops

1 answer 1

Try this:

 $sql = mysql_query("INSERT INTO users1 (`name`, `login`, `password`, `email`, `data`) Values ('" . $name . "', '" . $login."', '" . $password."', '" . $email."', '" . $data."')", $dbcon); 
  • This is a direct path to SQL injection. - Dmitriy Simushev
  • @DmitriySimushev, but the author did not seem to ask to be rewritten to PDO. :) - Christian Galliano
  • This does not justify potential problems with the results of your advice. And in the mysql extension there are ways to deal with SQL injections. It is strange that you do not know. - Dmitriy Simushev