Hello, please help me call the close method, I understand that maybe it’s easy and it’s easy for a person with experience, you need to close the main in the main after calling the updateImages method, there is a close() method for this, since getImagesDAO() already creates an instance class, it is necessary to close it after the method has worked

 public class DAOFactory implements DAOFactotyInterface { Connection connection = null; public Connection getConnection() throws DAOException { //получение соединения } return connection; } @Override public ImagesDAO getImagesDAO() throws DAOException { return new MySQLImagesDAO(getConnection()); public class MySQLImagesDAO implements ImagesDAO { private Connection connection = null; private PreparedStatement preparedStatement = null; public MySQLImagesDAO(Connection connection) { this.connection = connection; } private void getPreparedStatement(String sql) throws DAOException { if (preparedStatement == null) { try { preparedStatement = connection.prepareStatement(sql); } catch (Exception e) { throw new DAOException("Get preparedStatment failed.", e); } } } public void updateImages(Images images) throws DAOException { //метод update } }public void close() throws DAOException { //закрытие ps и соединения } public class Main { public static void main (String[] args){ DAOFactory test = new DAOFactory(); Images images = new Images(); images.setIdProfile(1); images.setAvatar("testLink"); images.setId(1); try { test.getImagesDAO().updateImages(images); //close? } catch (DAOException e) { e.printStackTrace(); } }
  • No, there are no static methods, you just need to call the close method so that it closes the already created DAO to execute the update method - PolkovnikJ

1 answer 1

Get a reference to the instance just like when you call other methods.

 test.getImagesDAO().close();

Plus, change the getter so that it does not create a new object each time.

 public class DAOFactory implements DAOFactotyInterface { Connection connection = null; public Connection getConnection() throws DAOException { //получение соединения } return connection; } MySQLImagesDAO instance; @Override public ImagesDAO getImagesDAO() throws DAOException { if(instance==null) { instance = new MySQLImagesDAO(getConnection()) } return instance; } }

UPD_0:

If you can not change the source code, then do so:

 ImagesDAO instance = test.getImagesDAO(); instance.updateImages(images); instance.close();
  • And while I do not create again a new object and close it immediately, in fact it is the second object, the first one will not be closed, correct it if it is not. - PolkovnikJ
  • one
    @PolkovnikJ, well, yes. Try to bring ImagesDAO into a class variable and in getImagesDAO () not to create a new instance every time, but return the same one. - Yuriy SPb ♦
  • one
    @PolkovnikJ, updated the answer. In the above code, getImagesDAO () will always return the same object - YuriySPb ♦
  • one
    @PolkovnikJ, updated the answer - YuriySPb ♦
  • one
    Excellent, it is a pity that I did not guess to such a simple solution, thanks for the help! - PolkovnikJ