How to disable the condition in the foreach loop

Question

There is a code for example:

foreach (DataRow row1 in ds.Tables[2].Rows) { if (String.IsNullOrEmpty(row1["clID"].ToString())) { // какое то действие dict.Add("{Note}", "Примечание"); break; } if (!String.IsNullOrEmpty(row1["clID"].ToString())) { // другое действие dict.Add("{Note}", "Заметка"); break; } }

The result of the procedure:

 | ID | clID | +----+------+ | 1 | 1444 | | 2 | 1456 | | 3 | null | | 4 | null |

How to cancel the 2nd if if the 1st if is executed.
The problem is that after the first condition is met, it goes to the second one and displays an error
It is necessary if in the table at least one clID is null then the 1st if was executed
if in the table all clID is not null then the second condition

Your second if is already "canceled" by the break; statement break;
@Pavel Mayorov, yes, and the first if is also satisfied and an exception was thrown
You have a mistake elsewhere, and it has nothing to do with the "disconnection of the condition"
@Pavel Mayorov, in this case, the first if is done when we go into the array for the third time and cancel.
Then there was a problem if the second also satisfied our condition and also fulfilled and left an exception.
And I need if in the table at least one clID is zero, then the 1st if was performed and that's all

Accepted Answer · 2016-07-21T20:25:46

since the conditions here are opposite. you can replace two if with an if-else

 if (String.IsNullOrEmpty(row1["clID"].ToString())) { // какое то действие dict.Add("{Note}", "Примечание"); break; } else { // другое действие dict.Add("{Note}", "Заметка"); break; }

Perhaps you should consider using the Convert.ToString function instead of calling the ToString method. If row1 ["clID"] is already null , there will be no error when using the first function, and if the second is used, there will be an exception.

Update to the question: in this case, the condition must be checked before taking action, for example using the linq: method Any

 if(ds.Tables[2].Rows.AsEnumerable().Any(dr=>String.IsNullOrEmpty(Convert.ToString(row1["clID"])))){ foreach (DataRow row1 in ds.Tables[2].Rows) { // какое то действие dict.Add("{Note}", "Примечание"); } }else{ foreach (DataRow row1 in ds.Tables[2].Rows) { // другое действие dict.Add("{Note}", "Заметка"); } }

in this case, the second condition is also satisfied, that is, you need without else if (...)
@Zhandos, in my answer there is no else if as well as there is no second condition
here the first if is not executed as id = 1 clID is not null, but I need a foreach loop to check all the lines, and the first if is executed and did not go to the second

Bogdan daragan bogdan daragan 53 7 · Answer 2 · 2016-07-21T20:34:59

You can create a boolean variable as the execution flag, in the iterations we started the flag = false, if the condition is true, and read this flag where appropriate. At the end of the loop body, reset the flag to false.

Zhandos Zhandos 651 6 sixteen · Answer 3 · 2016-07-22T06:28:15

  Boolean isCond = false; foreach (DataRow row1 in ds.Tables[2].Rows) { if (String.IsNullOrEmpty(row1["clID"].ToString())) { // какое то действие dict.Add("{Note}", "Примечание"); isCond = true; break; } if (!isCond) { foreach (DataRow row1 in ds.Tables[2].Rows) { if (!String.IsNullOrEmpty(row1["clID"].ToString())) { // другое действие dict.Add("{Note}", "Заметка"); break; } } }

How to disable the condition in the foreach loop

3 answers 3

More articles: