Registration with ASP.NET MVC C #

Question

I make registration on the site for educational purposes. I want to prohibit creating users with the same login. I check for the same login in the interface implementation. Here is the code:

public void Add_New_User(User user) { User olduser = context.Users.FirstOrDefault(c=>c.LoginUser == user.LoginUser); if (olduser == null) { context.Users.Add(user); } else { throw new Exception(); } context.SaveChanges(); }

That is, if there is no user with such a login, then I register him. If there is a user with such a login, then I push out an error (And I want to change this error to something more beautiful. For example: to the message "There is already a user with this login").

If a user is registered, and there is already a user in the database with such a login, then his registration must be disabled ...

batya batya 239 3 15 · Accepted Answer · 2017-02-26T19:24:19

Sat down. I thought. And I decided that it is better to transfer the verification logic to the controller:

 [HttpPost] public ActionResult Registr(User user, HttpPostedFileBase image) { if (image != null) { user.IconUserType = image.ContentType; user.IconUserData = new byte[image.ContentLength]; image.InputStream.Read(user.IconUserData, 0, image.ContentLength); } User olduser = repository.Users.FirstOrDefault(u => u.LoginUser == user.LoginUser); if (olduser != null) { ModelState.AddModelError("", "Такой пользователь уже есть"); } if (user.Password == Request.Form["Повторите пароль"] && ModelState.IsValid) { TempData["Message"] = "Регистрация прошла успешно! Можете логиниться"; repository.Add_New_User(user); return Redirect("/Account/Login"); //С помошью такого перевода мы избегам ошибки, когда при перегрузке браузера мы два раза отправляем одни и теже данные } else if(user.Password != Request.Form["Повторите пароль"]) { ModelState.AddModelError("", "Пароли не совпадают"); } return View("Registr"); }

Is it possible to simplify this somehow, otherwise it seems to me that this controller turned out to be too big ...

Misha Misha 84 6 · Answer 2 · 2017-02-26T18:10:19

Why do in the method, and not in ActionResult? You can use remote Validation - http://www.c-sharpcorner.com/UploadFile/d87001/remote-validation-in-mvc/

SergeyE SergeyE 376 2 eleven · Answer 3 · 2017-02-26T18:34:45

 Public Class RegisterViewModel <Required(ErrorMessage:="Не указан логин")> <Display(Name:="Логин")> <RegularExpression("[A-z0-9_]{5,15}", ErrorMessage:="Допустимые символы - латиница, нижнее подчеркивание, цифры (5-15 символов)")> Public Property Login As String ' имя пользователя (логин) проверка на уникальность End Class

check

 If olduser IsNot Nothing Then ModelState.AddModelError("", "Пользователь с таким логином уже существует") End If

Registration with ASP.NET MVC C #

3 answers 3

More articles: