1. using $ js = file_get_contents getting data from a third-party site - title
  2. Further, I receive the received title in search
  3. I get the search result

The problem is that the function receiving $ js = file_get_contents 2 and more in the response uses one and uses one and gives the result.

That is, if I created 5 blocks in the admin panel (it will output 5 blocks with the results on my site) then $ js = file_get_contents will be processed 5 times, because of which several blocks on the site can be the same, since the results of running five $ js = file_get_contents may be partially the same (we get 5 titles, 2 or 3 of which may be identical), hence there will be repetitions on the site.

How to rewrite or fix my function so that $ js = file_get_contents runs once and displays as many blocks on the site as the title was obtained?

The title is searched in the string $ this-> url --- q = ". urlencode ($ itemtitle)."

Help please, it is very necessary but I will not master 100% :(

protected function getcates($nom){ $part = "snippet"; $js=file_get_contents('сайт.ру/script.js'); if(preg_match('#push\((?<json>.*?)\);#',$js,$match)){ $wares=json_decode($match['json'])->wares; foreach ($wares as $item) { $itemtitle = $item->title; $itemtitle = preg_replace('/[^\p{L}0-9 \!]/iu', ' ', $itemtitle); } } $this->url = "https://www.googleapis.com/youtube/v3/search?key={$this->config["key"]}&part=$part&order=date&maxResults=4&q=".urlencode($itemtitle)."&videoEmbeddable=true&videoSyndicated=true&type=video"; $data = $this->http(TRUE); $html = ""; foreach ($data->items as $yt) { $html .= "РЕЗУЛЬТАТ РАБОТЫ ФУНКЦИИ {$yt->id->videoId}{$yt->snippet->title}"; } if(!empty($html)){ $html = 'шапка блока'.$html.'футер блока'; } return $html; }

Thank!

 protected function getcates($nom){ $part = "snippet"; $js=file_get_contents('сайт.ру//…'); if(preg_match('#push\((?<json>.*?)\);#',$js,$match)){ $wares=json_decode($match['json'])->wares; $titles = []; foreach ($wares as $item) { $itemtitle = $item->title; $itemtitle = preg_replace('/[^\p{L}0-9 \!]/iu', ' ', $itemtitle); $titles[] = $itemtitle; } } //$html = ""; foreach ($titles as $itemtitle) { $this->url = "https://www.googleapis.com/youtube/v3/search?key={$this->config["key"]}&part=$part&order=date&maxResults=4&q=".urlencode($itemtitle)."&videoEmbeddable=true&videoSyndicated=true&type=video"; $data = $this->http(TRUE); $html = ""; foreach ($data->items as $yt) { $html .= "РЕЗУЛЬТАТ РАБОТЫ ФУНКЦИИ {$yt->id->videoId}{$yt->snippet->title}"; } } if(!empty($html)){ $html = 'шапка блока'.$html.'футер блока'; } return $html; }

    1 answer 1

    You have a problem with a useless loop:

     foreach ($wares as $item) { $itemtitle = $item->title; $itemtitle = preg_replace('/[^\p{L}0-9 \!]/iu', ' ', $itemtitle); }

    Only the last title processed.

    You need to add all the code to handle this title inside the loop, or collect them into an array and then iterate.

    For example:

     $titles = []; foreach ($wares as $item) { $itemtitle = $item->title; $itemtitle = preg_replace('/[^\p{L}0-9 \!]/iu', ' ', $itemtitle); $titles[] = $itemtitle; }

    And below, iterate the headers and build the necessary blocks:

     $html = ""; foreach ($titles as $itemtitle) { $this->url = "https://www.googleapis.com/youtube/v3/search?key={$this->config["key"]}&part=$part&order=date&maxResults=4&q=".urlencode($itemtitle)."&videoEmbeddable=true&videoSyndicated=true&type=video"; $html .= "..."; // ... }

    I think it is obvious that in this particular case, you can not build an array, but generate blocks directly in the first cycle.

    • Well, if it works - what to check? =) Comments are a bad place for code. - vp_arth
    • No, you had to change nothing) Minute - vp_arth
    • vp_arth, THANK YOU! Now it seems I understood :) - MicroRu
    • I did not see the calling code, now I don’t need to call this function many times ... - vp_arth
    • Let's continue the discussion in the chat . - MicroRu