CancellationTokenSource cts = new CancellationTokenSource(); Task th = new Task(OutHookProc.prockill, cts.Token);

I stop like this:

 cts.Cancel();

How to stop?

    2 answers 2

    You cannot stop a running task in the same way that you cannot stop a running thread. You can only ask the task to stop, and hope that he will listen to your request.

    If the OutHookProc.prockill method OutHookProc.prockill under your control, change its signature so that it also CancellationToken , pass the token also there and in the method from time to time check the token and stop working if the token requests it. If you call other asynchronous methods inside OutHookProc.prockill , pass them a token too.

    If the method is not under your control and does not provide means for stopping, you can’t stop it at all. The only thing that can be done is to ignore the result of the task execution, but at the same time it will continue to run in the background.

    • And if I just have public static void prockill(){ while(true) ... // тут просто килл поцессов } , what should I do better? - GooliveR
    • @ArteS, instead of true check the flag that you do not need to go out - Grundy
    • one
      @ArteS: For example, while (!token.IsCancellationRequested) ... - VladD
    • 2
      @VladD, but if you really want to - you can: R - Grundy
    • 2
      @Grundy: No, this is not “necessary”, this is “no time / desire / knowledge to do right”: - / - VladD

    I tried to do as described here.

      private static bool Round = true; static CancellationTokenSource cts; public static void Start() { cts = new CancellationTokenSource(); var task = Task.Run(() => prockill(cts.Token), cts.Token); } public static void prockill(CancellationToken cancellationToken) { while (Round) { try { foreach (string str in strArray) { Process[] processesByName = Process.GetProcessesByName(str); foreach (Process process in processesByName) process.Kill(); } Thread.Sleep(1000); cancellationToken.ThrowIfCancellationRequested(); } catch (Exception) { Round = false; } } } public static void Cancel() { cts.Cancel(); }

    I want your criticism, kicks) I want to understand the logic and what should not be done ?!

    [Edit] Changed the code a bit:

     static CancellationTokenSource cts = new CancellationTokenSource(); public static void Start() { var task = Task.Run(() => prockill(cts.Token)); } public static async Task prockill(CancellationToken cancellationToken) { try { while (!cancellationToken.IsCancellationRequested) { await Task.Delay(500, cancellationToken); foreach (string str in strArray) { Process[] processesByName = Process.GetProcessesByName(str); foreach (Process process in processesByName) process.Kill(); } } } catch (OperationCanceledException) { } catch (Exception) { // другая ошибка } } public static void Cancel() { cts.Cancel(); }

    It seems everything works ultra fast, nothing buggy. Looking for improvement tips, what can I add / change ?!

    • 2
      Wrong. Round can be removed. And checking the cancellationToken.IsCancellationRequested needs to be done inside the foreach . - Alexander Petrov
    • @AlexanderPetrov, And everything else is normal? - GooliveR
    • So it would be better for the static void prockill use async Task ? - GooliveR
    • It seems the code is correct, yes. Must work. - VladD
    • one
      Then put your answer checkbox - VladD