The problem in the implementation of the object

Question

This program in each word of the text removes the same letters as the first.

Example:

[In]: Hehllo, what's up - Hah.
[Out]: Hello, what's up - Ha

But I ran into a problem in punctuation. I don’t know how to associate a Пунктуация class with a Слово / Предложение class, so that, let's say, the '-' sign is not a Словом , since my word is separated by spaces on both sides. And that after each sentence put point \ question. mark - object Пунктуация .

Code:

  public class Lab4 { public static void main(String[] args){ String s = "Размер или длина массива — это общее количество элементов в массиве." + " Размер массива задаётся при создании массива и не может быть изменён в дальнейшем," + " другими словами нельзя убрать элементы из массива или добавить их туда, но" + " можно в существующие элементы присвоить новые значения."; Text text = new Text(s); System.out.println("Initial text:"); System.out.println(text.getAllText()); StringBuilder newText = new StringBuilder(); Sentence c; Word w; for(int i = 0; i < text.getSentences().length; i++){ c = new Sentence(text.getSentenceByIndex(i)); for(int j = 0; j < c.getWords().length; j++){ w = new Word(c.getWords()[j].getAllWord()); newText.append(w.removeChars()); newText.append(" "); } } System.out.println(newText); } } class Text { private Sentence[] sentences; private String allText; public Text(String allText){ String newAllText = allText.replaceAll("\\s+", " "); setAllText(newAllText); sentences = new Sentence[amountOfSentences()]; fillUpSentenceArray(); } public int amountOfSentences(){ return allText.split("\\.!?").length; } public void fillUpSentenceArray(){ for (int i = 0; i < amountOfSentences(); i++){ sentences[i] = new Sentence((allText.split("\\.!?"))[i]); } } public String getAllText() { return allText; } public Sentence[] getSentences() { return sentences; } public String getSentenceByIndex(int i){ return sentences[i].getAllSentence(); } public void setAllText(String allText) { this.allText = allText; } } class Sentence { private Word[] words; private Punctuation[] punctuations; private String allSentence; public Sentence(String allSentence){ this.allSentence = allSentence; words = new Word[countAmountOfWords()]; fillUpWordsArray(); punctuations = new Punctuation[countAmountOfPunct()]; fillUpPunctArray(); } public int countAmountOfWords(){ return allSentence.split(" ").length; } public int countAmountOfPunct(){ StringBuilder a = new StringBuilder(); for(int i = 0; i < allSentence.length(); i++){ if(allSentence.toCharArray()[i] == ',' || allSentence.toCharArray()[i] == '.' || allSentence.toCharArray()[i] == '-'){ a.append(allSentence.toCharArray()[i]); } } return a.length(); } public void fillUpWordsArray(){ for(int i = 0; i < countAmountOfWords(); i++){ words[i] = new Word((allSentence.split(" "))[i]); } } public void fillUpPunctArray(){ char[] charr = allSentence.toCharArray(); for(int i = 0; i < countAmountOfPunct(); i++){ if(charr[i] == ',' || charr[i] == '.' || charr[i] == '-'){ punctuations[i] = new Punctuation(charr[i]); } } } public Word[] getWords() { return words; } public String getAllSentence() { return allSentence; } } class Word { private Letter[] letters; private String allWord; public Word(String allWord){ this.allWord = allWord; letters = new Letter[countLengthofWord()]; fillUpLetterArray(); } public int countLengthofWord(){ return allWord.length(); } public void fillUpLetterArray(){ for (int i = 0; i < countLengthofWord(); i++){ letters[i] = new Letter(allWord.toCharArray()[i]); } } public StringBuilder removeChars(){ StringBuilder upDatedWord = new StringBuilder(countLengthofWord()); if (allWord.isEmpty()){ allWord = " "; } char distChar = allWord.charAt(0); upDatedWord.append(distChar); for (int i = 0; i < allWord.length(); i++){ if (allWord.isEmpty()){ continue; } if (Character.toLowerCase(distChar) != Character.toLowerCase(allWord.charAt(i))){ upDatedWord.append(allWord.charAt(i)); } } this.allWord = upDatedWord.toString(); return upDatedWord; } public String getAllWord() { return allWord; } } class Punctuation { private char symbol; public Punctuation(char symbol){ this.symbol = symbol; } public char getSymbol() { return symbol; } public void setSymbol(char symbol) { this.symbol = symbol; } } class Letter { private char letter; public Letter(char letter){ this.letter = letter; } public char getLetter() { return letter; } public void setLetter(char letter) { this.letter = letter; } } /*public void fillUpSentencePartArray(){ boolean flag = false; for(int i = 0; i < allSentence.toCharArray().length; i++){ if(Character.isLetter(allSentence.toCharArray()[i])){ char[] temp = new char[20]; temp[i] = allSentence.toCharArray()[i]; if(flag){ Word wordToAdd = new Word(temp.toString()); sentenceParts[i] = wordToAdd; } } else if(allSentence.toCharArray()[i] == '.' || allSentence.toCharArray()[i] == ','){ Punctuation znakToAdd = new Punctuation(allSentence.toCharArray()[i]); sentenceParts[i] = znakToAdd; } else flag = true; } } */

Why don't you create a SentencePart interface without methods.
Then in the Sentence class, you can use SentencePart [] instead of Word [].
This will help preserve the order of words and punctuation in the sentence.
If you want to "process" only words, whatever is meant by this term, you can check the class of an object (instanceof) and if it is Word, then cast the object to it and "process"
We need to make an array of words and punctuation in the interface?
I caught the essence, but I misunderstand how to implement ...

Accepted Answer · 2018-03-13T09:43:05

I can write:

 interface SentensePart {} class Word implements SentensePart {...} class Punctuation implements SentensePart {...} class Sentence { //private Word[] words; //private Punctuation[] punctuations; //вместо этих двух строк с массивами классов используем один массив с общим интерфейсом: private SentensePart[] sentenseParts; //Последний элемент в этом массиве должен принадлежать классу Punctuation

To understand that we have the word, you can use instaceof and casting to the class:

 SentensePart sentensePart = ...; if (sentensePart instanceof Word) { Word word = (Word) sentensePart; //и далее работаем уже с типом word

I didn’t read your methods, but what else can I notice:

why do you even need the Letter class? What is not satisfied with the Character?
Punctuation contains only one character. And dots than offended?
can be not only a punctuation mark, but also a hyphen.

UPD. To comment:

 public void fillUpSentencePartArray(){ boolean flag = false; for(int i = 0; i < allSentence.toCharArray().length; i++){ //можно воспользоваться функцией allSentence.charAt(i) if(Character.isLetter(allSentence.toCharArray()[i])){ //Здесь вы создаете новый массив при каждой новой букве, //старый ссылка массив при этом теряется. Вместо массива //фиксированной длины имхо вообще лучше использовать //StringBuilder. Объявлять его или массив надо до цикла, //чтобы ссылка была действительна при разных итерациях цикла char[] temp = new char[20]; //В следующей строке вы обращаетесь к элементу массива temp, //с длиной 20, по индексу i который, может быть до //allSentence.length temp[i] = allSentence.toCharArray()[i]; if(flag){ Word wordToAdd = new Word(temp.toString()); //здесь опять ошибка с индексом. i - это индекс символа, //а не индекс в массиве sentenceParts. sentenceParts[i] = wordToAdd; } } else if(allSentence.toCharArray()[i] == '.' || allSentence.toCharArray()[i] == ','){ Punctuation znakToAdd = new Punctuation(allSentence.toCharArray()[i]); //та же ошибка с индексом. sentenceParts[i] = znakToAdd; } else flag = true; } }

2. I didn’t add it because I first wanted to test for performance.
In my code, the word can be with a punctuation mark, but I need them to be separately (for example, туда, is this word) and how can we parse if we have an array of objects?
So what's the difficulty: read the character, if not a space and not a punctuation mark, then add to the current word.
If the space - means the word is over, and add it to the array sentensePart.
If the punctuation mark, then add the word first, then the punctuation mark.

The problem in the implementation of the object

1 answer 1

More articles: